LaLeV/wacrm
1
0
Fork 0
mirror of https://github.com/Luchexx/wacrm.git synced 2026-11-02 09:19:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(automations): order send_template params numerically, not lexicographically

Browse Source 
Meta's template placeholders are positional ({{1}}, {{2}}, …). We
previously sorted the keys of step_config.variables lexicographically,
so a template with ≥10 variables got params in the order
"1", "10", "2", …, silently scrambling every render past the 9th
placeholder. Fix: sort numeric-looking keys by numeric value, fall back
to locale compare for non-numeric keys.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Arnas Donauskas 2026-04-17 21:36:40 +03:00
parent 59d0ea6e17
commit f25f20ed63
No known key found for this signature in database
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/automations/engine.ts
View File

@ -315,9 +315,22 @@ async function runStep(step: AutomationStep, args: ExecuteArgs): Promise<string>
if (!args.contactId) throw new Error('send_template needs a contact') if (!args.contactId) throw new Error('send_template needs a contact')
if (!cfg.template_name) throw new Error('send_template needs template_name') if (!cfg.template_name) throw new Error('send_template needs template_name')
const conversationId = await resolveConversationId(args) const conversationId = await resolveConversationId(args)
// Meta templates use positional {{1}}, {{2}}, … placeholders, so
// we MUST emit params in strict numeric order. Lexicographic sort
// of "1", "2", …, "10" yields "1", "10", "2", … which silently
// scrambles every template with ≥10 variables.
const params = cfg.variables const params = cfg.variables
? Object.keys(cfg.variables) ? Object.keys(cfg.variables)
.sort() .sort((a, b) => {
const na = Number(a)
const nb = Number(b)
const aNum = Number.isFinite(na)
const bNum = Number.isFinite(nb)
if (aNum && bNum) return na - nb
if (aNum) return -1
if (bNum) return 1
return a.localeCompare(b)
})
.map((k) => String(cfg.variables![k])) .map((k) => String(cfg.variables![k]))
: [] : []
const { whatsapp_message_id } = await engineSendTemplate({ const { whatsapp_message_id } = await engineSendTemplate({