From ec137c6fa584c2ab2ab7b651bfc7660417f9d357 Mon Sep 17 00:00:00 2001 From: Nicolas Pastorello Date: Wed, 29 Jul 2026 13:52:51 -0300 Subject: [PATCH] fix(i18n): label the contact name field with its own key MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Details tab rendered `t("company")` above the name input, so the panel showed "Company" twice and the name field carried the wrong label — in English as well as Korean. There was no `Contacts.detailView.name` key at all; the call papered over it with `{ fallback: "Name" }`, which next-intl ignores (the second argument is ICU values, not options). Add the missing key to both catalogues, point the label at it, and drop the two decorative `fallback` arguments so the remaining call sites read as what they are. --- messages/en.json | 1 + messages/ko.json | 1 + src/components/contacts/contact-detail-view.tsx | 4 ++-- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/messages/en.json b/messages/en.json index 846be95..100527c 100644 --- a/messages/en.json +++ b/messages/en.json @@ -371,6 +371,7 @@ "contactInfo": "Contact Information", "unnamed": "Unknown", "contactDetailsDesc": "Contact details", + "name": "Name", "phone": "Phone", "email": "Email", "company": "Company", diff --git a/messages/ko.json b/messages/ko.json index 01c612c..e4e2004 100644 --- a/messages/ko.json +++ b/messages/ko.json @@ -371,6 +371,7 @@ "contactInfo": "연락처 정보", "unnamed": "알 수 없음", "contactDetailsDesc": "연락처 정보", + "name": "이름", "phone": "전화번호", "email": "이메일", "company": "회사", diff --git a/src/components/contacts/contact-detail-view.tsx b/src/components/contacts/contact-detail-view.tsx index 4a0c3fb..9a28670 100644 --- a/src/components/contacts/contact-detail-view.tsx +++ b/src/components/contacts/contact-detail-view.tsx @@ -462,7 +462,7 @@ export function ContactDetailView({ value="tags" className="data-active:bg-muted data-active:text-primary text-muted-foreground" > - {t('tabs.tags', { fallback: 'Tags' })} + {t('tabs.tags')}
- + setEditName(e.target.value)}