LaLeV/wacrm
1
0
Fork 0
mirror of https://github.com/Luchexx/wacrm.git synced 2026-11-02 09:19:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(migration-014): drop subquery from buttons CHECK (Postgres disallows it)

Browse Source 
Postgres rejects CHECK constraints that contain subqueries with
SQLSTATE 0A000 — `NOT EXISTS (SELECT 1 FROM jsonb_array_elements(...))`
inside CHECK is illegal even though it parses.

Move per-element validation entirely to the API layer (the upcoming
template-validators in PR 3). The DB CHECK keeps the cheap shape
guard: NULL or an array of length <= 10. Per-element validation
needs specific error messages anyway ("button #3 has no `text` field")
which API-layer validators do much better than a CHECK violation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Arnas Donauskas 2026-05-29 12:21:14 +02:00
parent aa4f34c94c
commit ddf15184c8
No known key found for this signature in database
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
supabase/migrations/014_message_templates_meta_integration.sql
View File

@ -123,10 +123,14 @@ END $$;
-- New default for fresh inserts. -- New default for fresh inserts.
ALTER TABLE message_templates ALTER COLUMN status SET DEFAULT 'DRAFT'; ALTER TABLE message_templates ALTER COLUMN status SET DEFAULT 'DRAFT';
-- 4. buttons shape guard. Permissive at the DB level — strict per-type -- 4. buttons shape guard. Postgres disallows subqueries in CHECK
-- validation (max counts per type, QUICK_REPLY-vs-CTA exclusivity, -- constraints, so we can only assert the outer shape here (is-array
-- URL example required when {{1}} is present) lives in the API -- + max length). Per-element type validation (recognised `type`
-- validators so error messages can be specific. -- values, max counts per type, QUICK_REPLY-vs-CTA exclusivity, URL
-- example required when {{1}} is present) lives in the API
-- validators in src/lib/whatsapp/template-validators.ts — that's
-- where error messages can be specific to the offending button
-- anyway.
DO $$ DO $$
BEGIN BEGIN
IF NOT EXISTS ( IF NOT EXISTS (
@ -142,15 +146,6 @@ BEGIN
OR ( OR (
jsonb_typeof(buttons) = 'array' jsonb_typeof(buttons) = 'array'
AND jsonb_array_length(buttons) <= 10 AND jsonb_array_length(buttons) <= 10
AND NOT EXISTS (
SELECT 1
FROM jsonb_array_elements(buttons) AS b
WHERE jsonb_typeof(b) <> 'object'
OR NOT (b ? 'type')
OR (b->>'type') NOT IN (
'QUICK_REPLY', 'URL', 'PHONE_NUMBER', 'COPY_CODE'
)
)
) )
); );
END IF; END IF;