mirror of
https://github.com/Luchexx/wacrm.git
synced 2026-11-02 09:19:51 +00:00
feat(inbox): gate media send behind 'chat_media' beta flag
Media sends (photo/video/document/voice) are now opt-in per account via
the existing profiles.beta_features mechanism (migration 011 — same
pattern used to dogfood Flows before GA). No migration needed.
- New shared `hasBetaFeature` + `CHAT_MEDIA_BETA` ('chat_media') key, and
a `useBetaFeature` client hook mirroring useCan (false while loading).
- Composer: the attach menu, hidden file inputs, and voice recorder only
render when the flag is on; the hint indent reverts so non-beta users
see the unchanged text + template composer.
- Server: the send route rejects media kinds (403) and the transcode
route rejects (403) unless the caller's profile is opted in — so the
endpoints can't be driven ahead of the rollout. Text + templates stay
available to everyone.
Enable for one account via Supabase Studio:
UPDATE profiles SET beta_features = array_append(beta_features, 'chat_media')
WHERE email = 'someone@example.com';
Tests: hasBetaFeature null-safety + membership (419 total). typecheck/lint/build green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
parent
96e7a56e3e
commit
873ba1f4c6
@ -21,6 +21,7 @@ import {
|
|||||||
} from '@/lib/rate-limit'
|
} from '@/lib/rate-limit'
|
||||||
import type { MessageTemplate } from '@/types'
|
import type { MessageTemplate } from '@/types'
|
||||||
import { isMessageTemplate } from '@/lib/whatsapp/template-row-guard'
|
import { isMessageTemplate } from '@/lib/whatsapp/template-row-guard'
|
||||||
|
import { hasBetaFeature, CHAT_MEDIA_BETA } from '@/lib/auth/beta-features'
|
||||||
|
|
||||||
export async function POST(request: Request) {
|
export async function POST(request: Request) {
|
||||||
try {
|
try {
|
||||||
@ -51,7 +52,7 @@ export async function POST(request: Request) {
|
|||||||
// returned nothing for teammates who didn't author the row.
|
// returned nothing for teammates who didn't author the row.
|
||||||
const { data: profile } = await supabase
|
const { data: profile } = await supabase
|
||||||
.from('profiles')
|
.from('profiles')
|
||||||
.select('account_id')
|
.select('account_id, beta_features')
|
||||||
.eq('user_id', user.id)
|
.eq('user_id', user.id)
|
||||||
.maybeSingle()
|
.maybeSingle()
|
||||||
const accountId = profile?.account_id as string | undefined
|
const accountId = profile?.account_id as string | undefined
|
||||||
@ -119,6 +120,17 @@ export async function POST(request: Request) {
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Media sends are beta-gated (issue #213). Text + templates stay
|
||||||
|
// available to everyone; only accounts opted into 'chat_media' may
|
||||||
|
// send media — mirrors the client gate so the endpoint can't be
|
||||||
|
// driven ahead of the rollout.
|
||||||
|
if (isMediaKind && !hasBetaFeature(profile?.beta_features, CHAT_MEDIA_BETA)) {
|
||||||
|
return NextResponse.json(
|
||||||
|
{ error: 'Media messages are not enabled for your account.' },
|
||||||
|
{ status: 403 }
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
// Meta caps media captions at 1024 chars; reject before the upload is
|
// Meta caps media captions at 1024 chars; reject before the upload is
|
||||||
// wasted at the Meta call. (Audio carries no caption — see meta-api.)
|
// wasted at the Meta call. (Audio carries no caption — see meta-api.)
|
||||||
if (
|
if (
|
||||||
|
|||||||
@ -11,6 +11,7 @@ import {
|
|||||||
RATE_LIMITS,
|
RATE_LIMITS,
|
||||||
} from '@/lib/rate-limit'
|
} from '@/lib/rate-limit'
|
||||||
import { buildFfmpegArgs } from '@/lib/whatsapp/audio-transcode'
|
import { buildFfmpegArgs } from '@/lib/whatsapp/audio-transcode'
|
||||||
|
import { hasBetaFeature, CHAT_MEDIA_BETA } from '@/lib/auth/beta-features'
|
||||||
|
|
||||||
// ffmpeg + temp-file I/O need the Node runtime (not Edge).
|
// ffmpeg + temp-file I/O need the Node runtime (not Edge).
|
||||||
export const runtime = 'nodejs'
|
export const runtime = 'nodejs'
|
||||||
@ -69,6 +70,20 @@ export async function POST(request: Request) {
|
|||||||
return rateLimitResponse(limit)
|
return rateLimitResponse(limit)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Voice notes are part of the beta-gated media feature — only opted-in
|
||||||
|
// accounts may transcode (mirrors the send route + client gate).
|
||||||
|
const { data: profile } = await supabase
|
||||||
|
.from('profiles')
|
||||||
|
.select('beta_features')
|
||||||
|
.eq('user_id', user.id)
|
||||||
|
.maybeSingle()
|
||||||
|
if (!hasBetaFeature(profile?.beta_features, CHAT_MEDIA_BETA)) {
|
||||||
|
return NextResponse.json(
|
||||||
|
{ error: 'Voice notes are not enabled for your account.' },
|
||||||
|
{ status: 403 },
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
const ffmpegPath = resolveFfmpegPath()
|
const ffmpegPath = resolveFfmpegPath()
|
||||||
if (!ffmpegPath) {
|
if (!ffmpegPath) {
|
||||||
console.error('[transcode-audio] ffmpeg binary not found')
|
console.error('[transcode-audio] ffmpeg binary not found')
|
||||||
|
|||||||
@ -28,6 +28,8 @@ import {
|
|||||||
DropdownMenuTrigger,
|
DropdownMenuTrigger,
|
||||||
} from "@/components/ui/dropdown-menu";
|
} from "@/components/ui/dropdown-menu";
|
||||||
import { useCan } from "@/hooks/use-can";
|
import { useCan } from "@/hooks/use-can";
|
||||||
|
import { useBetaFeature } from "@/hooks/use-beta-feature";
|
||||||
|
import { CHAT_MEDIA_BETA } from "@/lib/auth/beta-features";
|
||||||
import { cn } from "@/lib/utils";
|
import { cn } from "@/lib/utils";
|
||||||
import { toast } from "sonner";
|
import { toast } from "sonner";
|
||||||
import {
|
import {
|
||||||
@ -165,6 +167,10 @@ export function MessageComposer({
|
|||||||
const readOnly = !canSend;
|
const readOnly = !canSend;
|
||||||
// Media (like free-form text) is only allowed inside the 24h window.
|
// Media (like free-form text) is only allowed inside the 24h window.
|
||||||
const inputsDisabled = readOnly || sessionExpired;
|
const inputsDisabled = readOnly || sessionExpired;
|
||||||
|
// Beta-gated: only accounts opted into 'chat_media' see the attach
|
||||||
|
// menu / voice recorder. Everyone else gets the original text + template
|
||||||
|
// composer with no visible change.
|
||||||
|
const chatMediaEnabled = useBetaFeature(CHAT_MEDIA_BETA);
|
||||||
|
|
||||||
const clearTimer = useCallback(() => {
|
const clearTimer = useCallback(() => {
|
||||||
if (timerRef.current !== null) {
|
if (timerRef.current !== null) {
|
||||||
@ -427,7 +433,10 @@ export function MessageComposer({
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Hidden file inputs driven by the attach menu. */}
|
{/* Hidden file inputs driven by the attach menu — only mounted when
|
||||||
|
the beta feature is on. */}
|
||||||
|
{chatMediaEnabled && (
|
||||||
|
<>
|
||||||
<input
|
<input
|
||||||
ref={imageInputRef}
|
ref={imageInputRef}
|
||||||
type="file"
|
type="file"
|
||||||
@ -458,6 +467,8 @@ export function MessageComposer({
|
|||||||
e.target.value = "";
|
e.target.value = "";
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
|
||||||
{draft ? (
|
{draft ? (
|
||||||
<MediaDraftPreview
|
<MediaDraftPreview
|
||||||
@ -494,7 +505,9 @@ export function MessageComposer({
|
|||||||
</div>
|
</div>
|
||||||
) : (
|
) : (
|
||||||
<div className="flex items-end gap-2">
|
<div className="flex items-end gap-2">
|
||||||
{/* Attach menu — photo / video / document / voice. */}
|
{/* Attach menu — photo / video / document / voice. Beta-gated:
|
||||||
|
hidden entirely for accounts not opted into 'chat_media'. */}
|
||||||
|
{chatMediaEnabled && (
|
||||||
<DropdownMenu>
|
<DropdownMenu>
|
||||||
<DropdownMenuTrigger
|
<DropdownMenuTrigger
|
||||||
disabled={inputsDisabled || busy}
|
disabled={inputsDisabled || busy}
|
||||||
@ -532,6 +545,7 @@ export function MessageComposer({
|
|||||||
</DropdownMenuItem>
|
</DropdownMenuItem>
|
||||||
</DropdownMenuContent>
|
</DropdownMenuContent>
|
||||||
</DropdownMenu>
|
</DropdownMenu>
|
||||||
|
)}
|
||||||
|
|
||||||
<GatedButton
|
<GatedButton
|
||||||
variant="ghost"
|
variant="ghost"
|
||||||
@ -586,7 +600,14 @@ export function MessageComposer({
|
|||||||
`items-end` buttons below the textarea. Indented to line up
|
`items-end` buttons below the textarea. Indented to line up
|
||||||
under the textarea left edge. */}
|
under the textarea left edge. */}
|
||||||
{!draft && !recording && (
|
{!draft && !recording && (
|
||||||
<p className="mt-1 pl-[5.5rem] text-[10px] text-muted-foreground">
|
<p
|
||||||
|
className={cn(
|
||||||
|
"mt-1 text-[10px] text-muted-foreground",
|
||||||
|
// Line up under the textarea: one button (template) when the
|
||||||
|
// attach menu is hidden, two when the beta feature adds it.
|
||||||
|
chatMediaEnabled ? "pl-[5.5rem]" : "pl-11",
|
||||||
|
)}
|
||||||
|
>
|
||||||
Type '/' for quick replies
|
Type '/' for quick replies
|
||||||
</p>
|
</p>
|
||||||
)}
|
)}
|
||||||
|
|||||||
20
src/hooks/use-beta-feature.ts
Normal file
20
src/hooks/use-beta-feature.ts
Normal file
@ -0,0 +1,20 @@
|
|||||||
|
"use client";
|
||||||
|
|
||||||
|
import { useAuth } from "@/hooks/use-auth";
|
||||||
|
import { hasBetaFeature, type BetaFeature } from "@/lib/auth/beta-features";
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Boolean gate for a per-profile beta feature flag (see
|
||||||
|
* `@/lib/auth/beta-features`). Mirrors `useCan`: returns `false` while the
|
||||||
|
* profile is still loading so a not-yet-opted-in user never sees a flash
|
||||||
|
* of beta UI during the initial load window.
|
||||||
|
*
|
||||||
|
* Example:
|
||||||
|
* const chatMedia = useBetaFeature(CHAT_MEDIA_BETA);
|
||||||
|
* {chatMedia && <AttachButton />}
|
||||||
|
*/
|
||||||
|
export function useBetaFeature(feature: BetaFeature): boolean {
|
||||||
|
const { profileLoading, profile } = useAuth();
|
||||||
|
if (profileLoading || !profile) return false;
|
||||||
|
return hasBetaFeature(profile.beta_features, feature);
|
||||||
|
}
|
||||||
19
src/lib/auth/beta-features.test.ts
Normal file
19
src/lib/auth/beta-features.test.ts
Normal file
@ -0,0 +1,19 @@
|
|||||||
|
import { describe, expect, it } from "vitest";
|
||||||
|
import { CHAT_MEDIA_BETA, hasBetaFeature } from "./beta-features";
|
||||||
|
|
||||||
|
describe("hasBetaFeature", () => {
|
||||||
|
it("is true when the feature key is present", () => {
|
||||||
|
expect(hasBetaFeature([CHAT_MEDIA_BETA], CHAT_MEDIA_BETA)).toBe(true);
|
||||||
|
expect(hasBetaFeature(["flows", CHAT_MEDIA_BETA], CHAT_MEDIA_BETA)).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("is false when the key is absent", () => {
|
||||||
|
expect(hasBetaFeature(["flows"], CHAT_MEDIA_BETA)).toBe(false);
|
||||||
|
expect(hasBetaFeature([], CHAT_MEDIA_BETA)).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("is false (not throwing) for null / undefined lists", () => {
|
||||||
|
expect(hasBetaFeature(null, CHAT_MEDIA_BETA)).toBe(false);
|
||||||
|
expect(hasBetaFeature(undefined, CHAT_MEDIA_BETA)).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
31
src/lib/auth/beta-features.ts
Normal file
31
src/lib/auth/beta-features.ts
Normal file
@ -0,0 +1,31 @@
|
|||||||
|
/**
|
||||||
|
* Beta feature flags, stored per-profile in `profiles.beta_features`
|
||||||
|
* (a `TEXT[]`, migration 011). A feature is "on" for an account when its
|
||||||
|
* key is present in that array; the owner opts in by editing the column
|
||||||
|
* in Supabase Studio:
|
||||||
|
*
|
||||||
|
* UPDATE profiles
|
||||||
|
* SET beta_features = array_append(beta_features, 'chat_media')
|
||||||
|
* WHERE email = 'someone@example.com';
|
||||||
|
*
|
||||||
|
* This module is the single source of truth for the keys + the membership
|
||||||
|
* check so the client hook (`useBetaFeature`) and the server routes gate
|
||||||
|
* on exactly the same logic.
|
||||||
|
*/
|
||||||
|
|
||||||
|
/** Agent-initiated media sends in the inbox composer (issue #213). */
|
||||||
|
export const CHAT_MEDIA_BETA = "chat_media";
|
||||||
|
|
||||||
|
export type BetaFeature = typeof CHAT_MEDIA_BETA;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Whether an opted-in feature list contains `feature`. Pure + null-safe so
|
||||||
|
* both the client (reading `profile.beta_features`) and the server
|
||||||
|
* (reading the row from Supabase) share one implementation.
|
||||||
|
*/
|
||||||
|
export function hasBetaFeature(
|
||||||
|
betaFeatures: readonly string[] | null | undefined,
|
||||||
|
feature: BetaFeature,
|
||||||
|
): boolean {
|
||||||
|
return betaFeatures?.includes(feature) ?? false;
|
||||||
|
}
|
||||||
Loading…
Reference in New Issue
Block a user